summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavoars@kernel.org>2020-06-17 18:15:57 -0500
committerDavid S. Miller <davem@davemloft.net>2020-06-18 20:41:02 -0700
commit9f66a4557e9338eecee4159834c3d1ec4a327158 (patch)
tree305d6d085d541dcdd1c54f382ec1350ce6fab56c
parentc90834cd477a6e406c320c56774999a71a859600 (diff)
downloadlinux-stable-9f66a4557e9338eecee4159834c3d1ec4a327158.tar.gz
linux-stable-9f66a4557e9338eecee4159834c3d1ec4a327158.tar.bz2
linux-stable-9f66a4557e9338eecee4159834c3d1ec4a327158.zip
mISDN: hfcsusb: Use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/hardware/mISDN/hfcsusb.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index 621364bb6b12..4274906f8654 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -261,8 +261,7 @@ hfcsusb_ph_info(struct hfcsusb *hw)
phi->bch[i].Flags = hw->bch[i].Flags;
}
_queue_data(&dch->dev.D, MPH_INFORMATION_IND, MISDN_ID_ANY,
- sizeof(struct ph_info_dch) + dch->dev.nrbchan *
- sizeof(struct ph_info_ch), phi, GFP_ATOMIC);
+ struct_size(phi, bch, dch->dev.nrbchan), phi, GFP_ATOMIC);
kfree(phi);
}