summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiasheng Jiang <jiasheng@iscas.ac.cn>2023-06-14 17:37:33 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-07-27 08:43:36 +0200
commita14cb307267ba7a1715403e071bdc4deda77eef5 (patch)
tree298591e3d94d5d62f7cef8064349e5e0108062c8
parent628709a05708918d17beddc9440b2d64320929c0 (diff)
downloadlinux-stable-a14cb307267ba7a1715403e071bdc4deda77eef5.tar.gz
linux-stable-a14cb307267ba7a1715403e071bdc4deda77eef5.tar.bz2
linux-stable-a14cb307267ba7a1715403e071bdc4deda77eef5.zip
pstore/ram: Add check for kstrdup
[ Upstream commit d97038d5ec2062733c1e016caf9baaf68cf64ea1 ] Add check for the return value of kstrdup() and return the error if it fails in order to avoid NULL pointer dereference. Fixes: e163fdb3f7f8 ("pstore/ram: Regularize prz label allocation lifetime") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230614093733.36048-1-jiasheng@iscas.ac.cn Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/pstore/ram_core.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 184cb97c83bd..b6183f1f4ebc 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -577,6 +577,8 @@ struct persistent_ram_zone *persistent_ram_new(phys_addr_t start, size_t size,
raw_spin_lock_init(&prz->buffer_lock);
prz->flags = flags;
prz->label = kstrdup(label, GFP_KERNEL);
+ if (!prz->label)
+ goto err;
ret = persistent_ram_buffer_map(start, size, prz, memtype);
if (ret)