diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-12-30 11:29:45 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-14 16:33:27 -0500 |
| commit | a23409cee466c636eb74e42c8a139ba9a714b0f5 (patch) | |
| tree | c967c97e3deed2c3cb7b81e9131357611a8ffada | |
| parent | ad13249bfa13ca20c66ad40345a97b72f739566f (diff) | |
| download | linux-stable-a23409cee466c636eb74e42c8a139ba9a714b0f5.tar.gz linux-stable-a23409cee466c636eb74e42c8a139ba9a714b0f5.tar.bz2 linux-stable-a23409cee466c636eb74e42c8a139ba9a714b0f5.zip | |
mtd: sharpslpart: Fix unsigned comparison to zero
commit f33113b542219448fa02d77ca1c6f4265bd7f130 upstream.
The unsigned variable log_num is being assigned a return value
from the call to sharpsl_nand_get_logical_num that can return
-EINVAL.
Detected using Coccinelle:
./drivers/mtd/parsers/sharpslpart.c:207:6-13: WARNING: Unsigned expression compared with zero: log_num > 0
Fixes: 8a4580e4d298 ("mtd: sharpslpart: Add sharpslpart partition parser")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/mtd/parsers/sharpslpart.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c index e5ea6127ab5a..671a61845bd5 100644 --- a/drivers/mtd/parsers/sharpslpart.c +++ b/drivers/mtd/parsers/sharpslpart.c @@ -165,10 +165,10 @@ static int sharpsl_nand_get_logical_num(u8 *oob) static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl) { - unsigned int block_num, log_num, phymax; + unsigned int block_num, phymax; + int i, ret, log_num; loff_t block_adr; u8 *oob; - int i, ret; oob = kzalloc(mtd->oobsize, GFP_KERNEL); if (!oob) |