diff options
| author | Fabio M. De Francesco <fmdefrancesco@gmail.com> | 2021-09-24 14:26:57 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-27 17:37:12 +0200 |
| commit | a3c1900154d0d164f9f4b507d22cce754243d6b6 (patch) | |
| tree | f3a149d7db80004ddb9dde35d48ce261e9cf55b4 | |
| parent | 7dc3f33ccbf862d8a660e36abcfef8f8c714b006 (diff) | |
| download | linux-stable-a3c1900154d0d164f9f4b507d22cce754243d6b6.tar.gz linux-stable-a3c1900154d0d164f9f4b507d22cce754243d6b6.tar.bz2 linux-stable-a3c1900154d0d164f9f4b507d22cce754243d6b6.zip | |
staging: r8188eu: change the type of a variable in rtw_write16()
Change the type of "data" from __le32 to __le16 in rtw_write16(). The
argument "val", which is u16, after being conditionally swapped to little
endian, is assigned to "data"; therefore, __le16 is the most suitable type
for "data". Remove the bitwise AND of "val" with 0xffff because it is
redundant. Use cpu_to_le16() because "data" is __le16.
Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-9-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/r8188eu/hal/usb_ops_linux.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 95cd7a6bc28b..5dcab1ee4be0 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -145,7 +145,7 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val) struct io_priv *io_priv = &adapter->iopriv; struct intf_hdl *intf = &io_priv->intf; u16 value = addr & 0xffff; - __le32 data = cpu_to_le32(val & 0x0000ffff); + __le16 data = cpu_to_le16(val); int ret; ret = usbctrl_vendorreq(intf, value, &data, 2, REALTEK_USB_VENQT_WRITE); |