diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2014-05-20 12:33:47 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-23 21:11:57 +0900 |
| commit | a3c97192fbc2fec6afa82a292c65adfd5cbde9b0 (patch) | |
| tree | c5006cf48412791fbf17b67545d3f7ca5086cc09 | |
| parent | ba9108080f861f7cccb58bdec900c4076c2bc803 (diff) | |
| download | linux-stable-a3c97192fbc2fec6afa82a292c65adfd5cbde9b0.tar.gz linux-stable-a3c97192fbc2fec6afa82a292c65adfd5cbde9b0.tar.bz2 linux-stable-a3c97192fbc2fec6afa82a292c65adfd5cbde9b0.zip | |
staging: ozwpan: Remove useless return variables
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/ozwpan/ozhcd.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 91bb29e09322..30bd9286d47d 100644 --- a/drivers/staging/ozwpan/ozhcd.c +++ b/drivers/staging/ozwpan/ozhcd.c @@ -2011,7 +2011,6 @@ static void oz_get_hub_descriptor(struct usb_hcd *hcd, static int oz_set_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex) { struct oz_port *port; - int err = 0; u8 port_id = (u8)windex; struct oz_hcd *ozhcd = oz_hcd_private(hcd); unsigned set_bits = 0; @@ -2078,7 +2077,7 @@ static int oz_set_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex) spin_unlock_bh(&port->port_lock); } oz_dbg(HUB, "Port[%d] status = 0x%x\n", port_id, port->status); - return err; + return 0; } /* @@ -2087,7 +2086,6 @@ static int oz_set_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex) static int oz_clear_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex) { struct oz_port *port; - int err = 0; u8 port_id = (u8)windex; struct oz_hcd *ozhcd = oz_hcd_private(hcd); unsigned clear_bits = 0; @@ -2154,7 +2152,7 @@ static int oz_clear_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex) } oz_dbg(HUB, "Port[%d] status = 0x%x\n", port_id, ozhcd->ports[port_id-1].status); - return err; + return 0; } /* |