summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhang Yi <yi.zhang@huawei.com>2024-04-19 10:30:05 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-05-30 09:44:59 +0200
commitad78fd91c569917202f46690e0fd46baac8e5c40 (patch)
tree638e3d83008f1740759346bd7ccc7251326804e8
parent4ab422499a9332e4312b67868a96568ac84cea13 (diff)
downloadlinux-stable-ad78fd91c569917202f46690e0fd46baac8e5c40.tar.gz
linux-stable-ad78fd91c569917202f46690e0fd46baac8e5c40.tar.bz2
linux-stable-ad78fd91c569917202f46690e0fd46baac8e5c40.zip
ext4: remove the redundant folio_wait_stable()
[ Upstream commit df0b5afc62f3368d657a8fe4a8d393ac481474c2 ] __filemap_get_folio() with FGP_WRITEBEGIN parameter has already wait for stable folio, so remove the redundant folio_wait_stable() in ext4_da_write_begin(), it was left over from the commit cc883236b792 ("ext4: drop unnecessary journal handle in delalloc write") that removed the retry getting page logic. Fixes: cc883236b792 ("ext4: drop unnecessary journal handle in delalloc write") Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240419023005.2719050-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/ext4/inode.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 537803250ca9..6de6bf57699b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2887,9 +2887,6 @@ retry:
if (IS_ERR(folio))
return PTR_ERR(folio);
- /* In case writeback began while the folio was unlocked */
- folio_wait_stable(folio);
-
#ifdef CONFIG_FS_ENCRYPTION
ret = ext4_block_write_begin(folio, pos, len, ext4_da_get_block_prep);
#else