summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhan liu <zhan.liu@amd.com>2019-11-25 17:25:18 -0500
committerAlex Deucher <alexander.deucher@amd.com>2019-11-26 14:51:03 -0500
commitadc8139e687ed58548a92cda541d10c57212cd38 (patch)
tree8c6f59205e5ba501697792fe63ce309233ece9b6
parentbe3e73ea7def13abbb481844aaaa073903e18b03 (diff)
downloadlinux-stable-adc8139e687ed58548a92cda541d10c57212cd38.tar.gz
linux-stable-adc8139e687ed58548a92cda541d10c57212cd38.tar.bz2
linux-stable-adc8139e687ed58548a92cda541d10c57212cd38.zip
drm/amd/display: Modify comments to match the code
[Why] This line of code was modified. However, comments remained unchanged. As a result, comments and code are mismatching. [How] Modifying comments to reflect code. At the same time, explaining why the value was changed from 200ms to 3000ms. Signed-off-by: Zhan Liu <zhan.liu@amd.com> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/display/dc/dc_helper.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/dc_helper.c b/drivers/gpu/drm/amd/display/dc/dc_helper.c
index 8da4576e2908..e41befa067ce 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_helper.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_helper.c
@@ -485,7 +485,12 @@ void generic_reg_wait(const struct dc_context *ctx,
return;
}
- /* something is terribly wrong if time out is > 200ms. (5Hz) */
+ /*
+ * Something is terribly wrong if time out is > 3000ms.
+ * 3000ms is the maximum time needed for SMU to pass values back.
+ * This value comes from experiments.
+ *
+ */
ASSERT(delay_between_poll_us * time_out_num_tries <= 3000000);
for (i = 0; i <= time_out_num_tries; i++) {