diff options
| author | Ahmad Fatoum <a.fatoum@pengutronix.de> | 2020-09-07 17:31:35 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-07 08:01:23 +0200 |
| commit | b079337f697aa6fcb3be991a68bb0f849ea1cd57 (patch) | |
| tree | 1d2fccf2f2c5decb73c46dbbdeabf97a2f682190 | |
| parent | 57bd08a301f7b4c1d7c3bdf3025c96f9721c9d74 (diff) | |
| download | linux-stable-b079337f697aa6fcb3be991a68bb0f849ea1cd57.tar.gz linux-stable-b079337f697aa6fcb3be991a68bb0f849ea1cd57.tar.bz2 linux-stable-b079337f697aa6fcb3be991a68bb0f849ea1cd57.zip | |
gpio: siox: explicitly support only threaded irqs
commit 45ccf6556720293323c20cda717756014ff63007 upstream.
The gpio-siox driver uses handle_nested_irq() to implement its
interrupt support. This is only capable of handling threaded irq
actions. For a hardirq action it triggers a NULL pointer oops.
(It calls action->thread_fn which is NULL then.)
Prevent registration of a hardirq action by setting
gpio_irq_chip::threaded to true.
Cc: u.kleine-koenig@pengutronix.de
Fixes: be8c8facc707 ("gpio: new driver to work with a 8x12 siox")
Cc: stable@vger.kernel.org
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/gpio/gpio-siox.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c index 006a7e6a75f2..7e70d2d06c3f 100644 --- a/drivers/gpio/gpio-siox.c +++ b/drivers/gpio/gpio-siox.c @@ -245,6 +245,7 @@ static int gpio_siox_probe(struct siox_device *sdevice) girq->chip = &ddata->ichip; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_level_irq; + girq->threaded = true; ret = devm_gpiochip_add_data(dev, &ddata->gchip, NULL); if (ret) |