summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNanyong Sun <sunnanyong@huawei.com>2021-09-07 20:00:23 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-09-26 14:07:13 +0200
commitb16f4acf6b65a22a01783fc62b669287bb9d8b0a (patch)
treeb5518ea7b99cff1f7e71f40187cac4eb4161761e
parent594addd4369e1255bb5bbe8e5ee104cb4eca2bbc (diff)
downloadlinux-stable-b16f4acf6b65a22a01783fc62b669287bb9d8b0a.tar.gz
linux-stable-b16f4acf6b65a22a01783fc62b669287bb9d8b0a.tar.bz2
linux-stable-b16f4acf6b65a22a01783fc62b669287bb9d8b0a.zip
nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group
[ Upstream commit 17243e1c3072b8417a5ebfc53065d0a87af7ca77 ] kobject_put() should be used to cleanup the memory associated with the kobject instead of kobject_del(). See the section "Kobject removal" of "Documentation/core-api/kobject.rst". Link: https://lkml.kernel.org/r/20210629022556.3985106-7-sunnanyong@huawei.com Link: https://lkml.kernel.org/r/1625651306-10829-7-git-send-email-konishi.ryusuke@gmail.com Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/nilfs2/sysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index 6c92ac314b06..28a2db3b1787 100644
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -215,7 +215,7 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root)
void nilfs_sysfs_delete_snapshot_group(struct nilfs_root *root)
{
- kobject_del(&root->snapshot_kobj);
+ kobject_put(&root->snapshot_kobj);
}
/************************************************************************