summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhang Xiaohui <ruc_zhangxiaohui@163.com>2020-12-06 16:48:01 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-01-09 13:43:48 +0100
commitb35029a1f24fe511af750537e6565dcf68e5c862 (patch)
tree1bedcd45b91a51bfeeec98e25e8cbe69dd7198ab
parentf817a9938e0652856a8dfceb29193f1f79ffc145 (diff)
downloadlinux-stable-b35029a1f24fe511af750537e6565dcf68e5c862.tar.gz
linux-stable-b35029a1f24fe511af750537e6565dcf68e5c862.tar.bz2
linux-stable-b35029a1f24fe511af750537e6565dcf68e5c862.zip
mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start
[ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ] mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix it by putting the length check before calling memcpy(). Signed-off-by: Zhang Xiaohui <ruc_zhangxiaohui@163.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20201206084801.26479-1-ruc_zhangxiaohui@163.com Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/net/wireless/marvell/mwifiex/join.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/wireless/marvell/mwifiex/join.c b/drivers/net/wireless/marvell/mwifiex/join.c
index d87aeff70cef..c2cb1e711c06 100644
--- a/drivers/net/wireless/marvell/mwifiex/join.c
+++ b/drivers/net/wireless/marvell/mwifiex/join.c
@@ -877,6 +877,8 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,
memset(adhoc_start->ssid, 0, IEEE80211_MAX_SSID_LEN);
+ if (req_ssid->ssid_len > IEEE80211_MAX_SSID_LEN)
+ req_ssid->ssid_len = IEEE80211_MAX_SSID_LEN;
memcpy(adhoc_start->ssid, req_ssid->ssid, req_ssid->ssid_len);
mwifiex_dbg(adapter, INFO, "info: ADHOC_S_CMD: SSID = %s\n",