summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBart Van Assche <bvanassche@acm.org>2021-10-07 13:28:39 -0700
committerMartin K. Petersen <martin.petersen@oracle.com>2021-10-16 21:28:48 -0400
commitb4b84edc5d3982749c342669b6fbef6ef239730e (patch)
treeaf4515d52475e2c8b4df019ec86a575992f4c9f1
parente0f63b2181cb66a7f8cd5b15ae6237fe0d283b0c (diff)
downloadlinux-stable-b4b84edc5d3982749c342669b6fbef6ef239730e.tar.gz
linux-stable-b4b84edc5d3982749c342669b6fbef6ef239730e.tar.bz2
linux-stable-b4b84edc5d3982749c342669b6fbef6ef239730e.zip
scsi: libiscsi: Call scsi_done() directly
Conditional statements are faster than indirect calls. Hence call scsi_done() directly. Link: https://lore.kernel.org/r/20211007202923.2174984-45-bvanassche@acm.org Reviewed-by: Lee Duncan <lduncanb@suse.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/libiscsi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 54dd9f581290..284b939fb1ea 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -468,7 +468,7 @@ static void iscsi_free_task(struct iscsi_task *task)
* it will decide how to return sc to scsi-ml.
*/
if (oldstate != ISCSI_TASK_REQUEUE_SCSIQ)
- sc->scsi_done(sc);
+ scsi_done(sc);
}
}
@@ -1807,7 +1807,7 @@ fault:
ISCSI_DBG_SESSION(session, "iscsi: cmd 0x%x is not queued (%d)\n",
sc->cmnd[0], reason);
scsi_set_resid(sc, scsi_bufflen(sc));
- sc->scsi_done(sc);
+ scsi_done(sc);
return 0;
}
EXPORT_SYMBOL_GPL(iscsi_queuecommand);