diff options
| author | Justin Stitt <justinstitt@google.com> | 2023-09-13 00:23:19 +0000 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-09-29 14:48:31 -0700 |
| commit | b545465e22f5fec2862132c01a5d2abd3c4c4d50 (patch) | |
| tree | e08a708146f040f4b43486daf9672743f871a40e | |
| parent | 0faf84caee63a5f331bda130265fdceb7d4101b5 (diff) | |
| download | linux-stable-b545465e22f5fec2862132c01a5d2abd3c4c4d50.tar.gz linux-stable-b545465e22f5fec2862132c01a5d2abd3c4c4d50.tar.bz2 linux-stable-b545465e22f5fec2862132c01a5d2abd3c4c4d50.zip | |
cpuidle: dt: Replace deprecated strncpy() with strscpy()
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy` [2] due to the fact that it guarantees
NUL-termination on the destination buffer. With this, we can also drop
the now unnecessary `CPUIDLE_(NAME|DESC)_LEN - 1` pieces.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230913-strncpy-drivers-cpuidle-dt_idle_states-c-v1-1-d16a0dbe5658@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
| -rw-r--r-- | drivers/cpuidle/dt_idle_states.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c index 12fec92a85fd..97feb7d8fb23 100644 --- a/drivers/cpuidle/dt_idle_states.c +++ b/drivers/cpuidle/dt_idle_states.c @@ -84,8 +84,8 @@ static int init_state_node(struct cpuidle_state *idle_state, * replace with kstrdup and pointer assignment when name * and desc become string pointers */ - strncpy(idle_state->name, state_node->name, CPUIDLE_NAME_LEN - 1); - strncpy(idle_state->desc, desc, CPUIDLE_DESC_LEN - 1); + strscpy(idle_state->name, state_node->name, CPUIDLE_NAME_LEN); + strscpy(idle_state->desc, desc, CPUIDLE_DESC_LEN); return 0; } |