diff options
| author | Pietro Borrello <borrello@diag.uniroma1.it> | 2023-02-09 12:26:23 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-10 09:33:02 +0100 |
| commit | b8dd6200fa8df618749cffb2096a3b5f4071f6e4 (patch) | |
| tree | 08067c924fa6a316b3495317ebfcecbc0e330037 | |
| parent | cd9dff330e8932653b13a15abc278c46ca73fe6f (diff) | |
| download | linux-stable-b8dd6200fa8df618749cffb2096a3b5f4071f6e4.tar.gz linux-stable-b8dd6200fa8df618749cffb2096a3b5f4071f6e4.tar.bz2 linux-stable-b8dd6200fa8df618749cffb2096a3b5f4071f6e4.zip | |
rds: rds_rm_zerocopy_callback() correct order for list_add_tail()
[ Upstream commit 68762148d1b011d47bc2ceed7321739b5aea1e63 ]
rds_rm_zerocopy_callback() uses list_add_tail() with swapped
arguments. This links the list head with the new entry, losing
the references to the remaining part of the list.
Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification")
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/rds/message.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/message.c b/net/rds/message.c index 9402bc941823..f71e1237e03d 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -118,7 +118,7 @@ static void rds_rm_zerocopy_callback(struct rds_sock *rs, ck = &info->zcookies; memset(ck, 0, sizeof(*ck)); WARN_ON(!rds_zcookie_add(info, cookie)); - list_add_tail(&q->zcookie_head, &info->rs_zcookie_next); + list_add_tail(&info->rs_zcookie_next, &q->zcookie_head); spin_unlock_irqrestore(&q->lock, flags); /* caller invokes rds_wake_sk_sleep() */ |