diff options
| author | Pan Bian <bianpan2016@163.com> | 2021-01-20 18:08:56 -0800 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2021-01-22 23:19:24 +0100 |
| commit | b9557caaf872271671bdc1ef003d72f421eb72f6 (patch) | |
| tree | d207bde825b0e0481d9251d15ff029c4b6c1a5aa | |
| parent | f4a2da755a7e1f5d845c52aee71336cee289935a (diff) | |
| download | linux-stable-b9557caaf872271671bdc1ef003d72f421eb72f6.tar.gz linux-stable-b9557caaf872271671bdc1ef003d72f421eb72f6.tar.bz2 linux-stable-b9557caaf872271671bdc1ef003d72f421eb72f6.zip | |
bpf, inode_storage: Put file handler if no storage was found
Put file f if inode_storage_ptr() returns NULL.
Fixes: 8ea636848aca ("bpf: Implement bpf_local_storage for inodes")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: KP Singh <kpsingh@kernel.org>
Link: https://lore.kernel.org/bpf/20210121020856.25507-1-bianpan2016@163.com
| -rw-r--r-- | kernel/bpf/bpf_inode_storage.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/kernel/bpf/bpf_inode_storage.c b/kernel/bpf/bpf_inode_storage.c index 2f0597320b6d..6639640523c0 100644 --- a/kernel/bpf/bpf_inode_storage.c +++ b/kernel/bpf/bpf_inode_storage.c @@ -125,8 +125,12 @@ static int bpf_fd_inode_storage_update_elem(struct bpf_map *map, void *key, fd = *(int *)key; f = fget_raw(fd); - if (!f || !inode_storage_ptr(f->f_inode)) + if (!f) + return -EBADF; + if (!inode_storage_ptr(f->f_inode)) { + fput(f); return -EBADF; + } sdata = bpf_local_storage_update(f->f_inode, (struct bpf_local_storage_map *)map, |