diff options
| author | Guo Ren <guoren@linux.alibaba.com> | 2022-04-06 22:28:43 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-09 10:23:26 +0200 |
| commit | ba810df878b0862e01b8e9d2158f7c74dfc76b96 (patch) | |
| tree | 19dee23256c9d3d578a4b9c65aaf378e6ac8d876 | |
| parent | f828af2c527de683b48f8463f7b5011b4b45a4f3 (diff) | |
| download | linux-stable-ba810df878b0862e01b8e9d2158f7c74dfc76b96.tar.gz linux-stable-ba810df878b0862e01b8e9d2158f7c74dfc76b96.tar.bz2 linux-stable-ba810df878b0862e01b8e9d2158f7c74dfc76b96.zip | |
csky: patch_text: Fixup last cpu should be master
commit 8c4d16471e2babe9bdfe41d6ef724526629696cb upstream.
These patch_text implementations are using stop_machine_cpuslocked
infrastructure with atomic cpu_count. The original idea: When the
master CPU patch_text, the others should wait for it. But current
implementation is using the first CPU as master, which couldn't
guarantee the remaining CPUs are waiting. This patch changes the
last CPU as the master to solve the potential risk.
Fixes: 33e53ae1ce41 ("csky: Add kprobes supported")
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | arch/csky/kernel/probes/kprobes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/csky/kernel/probes/kprobes.c b/arch/csky/kernel/probes/kprobes.c index 8fffa34d4e1c..4045894d9280 100644 --- a/arch/csky/kernel/probes/kprobes.c +++ b/arch/csky/kernel/probes/kprobes.c @@ -28,7 +28,7 @@ static int __kprobes patch_text_cb(void *priv) struct csky_insn_patch *param = priv; unsigned int addr = (unsigned int)param->addr; - if (atomic_inc_return(¶m->cpu_count) == 1) { + if (atomic_inc_return(¶m->cpu_count) == num_online_cpus()) { *(u16 *) addr = cpu_to_le16(param->opcode); dcache_wb_range(addr, addr + 2); atomic_inc(¶m->cpu_count); |