diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-08 10:13:56 -0600 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-05-09 14:26:16 -0700 |
commit | bc0025b6107c011e8f9411a275d8442a56bd573a (patch) | |
tree | 338fc6b87a97cb859c07fba1ef176263fc37be06 | |
parent | 5d5db1c94f8c412d1c9755bd13194701301b9046 (diff) | |
download | linux-stable-bc0025b6107c011e8f9411a275d8442a56bd573a.tar.gz linux-stable-bc0025b6107c011e8f9411a275d8442a56bd573a.tar.bz2 linux-stable-bc0025b6107c011e8f9411a275d8442a56bd573a.zip |
sparc: use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | arch/sparc/kernel/cpumap.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/sparc/kernel/cpumap.c b/arch/sparc/kernel/cpumap.c index d1d52822603d..1cb62bfeaa1f 100644 --- a/arch/sparc/kernel/cpumap.c +++ b/arch/sparc/kernel/cpumap.c @@ -194,8 +194,7 @@ static struct cpuinfo_tree *build_cpuinfo_tree(void) n = enumerate_cpuinfo_nodes(tmp_level); - new_tree = kzalloc(sizeof(struct cpuinfo_tree) + - (sizeof(struct cpuinfo_node) * n), GFP_ATOMIC); + new_tree = kzalloc(struct_size(new_tree, nodes, n), GFP_ATOMIC); if (!new_tree) return NULL; |