summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>2018-12-10 19:00:02 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-02-27 10:08:52 +0100
commitbeaf260ec8204729cbd8e4b3d19b37ed18b870b2 (patch)
treed45703abeef92d13fe1d6afe93e0c8123ddf5b8c
parentef1dc506cb50e86687d29b24c462954def12c3b6 (diff)
downloadlinux-stable-beaf260ec8204729cbd8e4b3d19b37ed18b870b2.tar.gz
linux-stable-beaf260ec8204729cbd8e4b3d19b37ed18b870b2.tar.bz2
linux-stable-beaf260ec8204729cbd8e4b3d19b37ed18b870b2.zip
mfd: cros_ec_dev: Add missing mfd_remove_devices() call in remove
[ Upstream commit 18e294ddafaeb80a1e2e10c9bd750a6cb8388d5b ] The driver adds different MFD child devices via mfd_add_devices() and hence it is required to call mfd_remove_devices() to remove MFD child devices. Fixes: 5e0115581bbc ("cros_ec: Move cros_ec_dev module to drivers/mfd") Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/mfd/cros_ec_dev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 6b22d54a540d..bccde3eac92c 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -499,6 +499,7 @@ static int ec_device_remove(struct platform_device *pdev)
cros_ec_debugfs_remove(ec);
+ mfd_remove_devices(ec->dev);
cdev_del(&ec->cdev);
device_unregister(&ec->class_dev);
return 0;