summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Loehle <christian.loehle@arm.com>2024-06-04 11:55:29 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2024-06-07 20:55:00 +0200
commitbf183113842b0fcf4b6f977a97fa9cf8e2b21625 (patch)
tree25fed17b41d59f4dc5866830e3f2adebd798102d
parent17c4fc386b0c936d60e975d584bba4769d1471f5 (diff)
downloadlinux-stable-bf183113842b0fcf4b6f977a97fa9cf8e2b21625.tar.gz
linux-stable-bf183113842b0fcf4b6f977a97fa9cf8e2b21625.tar.bz2
linux-stable-bf183113842b0fcf4b6f977a97fa9cf8e2b21625.zip
cpuidle: menu: Cleanup after loadavg removal
The performance impact of loadavg was removed with commit a7fe5190c03f ("cpuidle: menu: Remove get_loadavg() from the performance multiplier") With only iowait remaining the description can be simplified, remove also the no longer needed includes. Signed-off-by: Christian Loehle <christian.loehle@arm.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--drivers/cpuidle/governors/menu.c17
1 files changed, 5 insertions, 12 deletions
diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index b96e3da0fedd..f3c9d49f0f2a 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -14,8 +14,6 @@
#include <linux/ktime.h>
#include <linux/hrtimer.h>
#include <linux/tick.h>
-#include <linux/sched.h>
-#include <linux/sched/loadavg.h>
#include <linux/sched/stat.h>
#include <linux/math64.h>
@@ -95,16 +93,11 @@
* state, and thus the less likely a busy CPU will hit such a deep
* C state.
*
- * Two factors are used in determing this multiplier:
- * a value of 10 is added for each point of "per cpu load average" we have.
- * a value of 5 points is added for each process that is waiting for
- * IO on this CPU.
- * (these values are experimentally determined)
- *
- * The load average factor gives a longer term (few seconds) input to the
- * decision, while the iowait value gives a cpu local instantanious input.
- * The iowait factor may look low, but realize that this is also already
- * represented in the system load average.
+ * Currently there is only one value determining the factor:
+ * 10 points are added for each process that is waiting for IO on this CPU.
+ * (This value was experimentally determined.)
+ * Utilization is no longer a factor as it was shown that it never contributed
+ * significantly to the performance multiplier in the first place.
*
*/