diff options
| author | Kees Cook <keescook@chromium.org> | 2023-09-22 10:53:35 -0700 |
|---|---|---|
| committer | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2023-11-05 21:15:17 +0900 |
| commit | c12d7aa7ffa4c61443241fbc1ee405acf4aa17de (patch) | |
| tree | d5b3d9545cdbdc1bee20c2a96331d9d40b79b91a | |
| parent | ffc253263a1375a65fa6c9f62a893e9767fbebfa (diff) | |
| download | linux-stable-c12d7aa7ffa4c61443241fbc1ee405acf4aa17de.tar.gz linux-stable-c12d7aa7ffa4c61443241fbc1ee405acf4aa17de.tar.bz2 linux-stable-c12d7aa7ffa4c61443241fbc1ee405acf4aa17de.zip | |
firewire: Annotate struct fw_node with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct fw_node.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: linux1394-devel@lists.sourceforge.net
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922175334.work.335-kees@kernel.org
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
| -rw-r--r-- | drivers/firewire/core.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firewire/core.h b/drivers/firewire/core.h index 2a05f411328f..95c10f3d2282 100644 --- a/drivers/firewire/core.h +++ b/drivers/firewire/core.h @@ -191,7 +191,7 @@ struct fw_node { /* Upper layer specific data. */ void *data; - struct fw_node *ports[]; + struct fw_node *ports[] __counted_by(port_count); }; static inline struct fw_node *fw_node_get(struct fw_node *node) |