diff options
| author | Tao Ma <tao.ma@oracle.com> | 2009-08-18 11:44:07 +0800 |
|---|---|---|
| committer | Joel Becker <joel.becker@oracle.com> | 2009-09-22 20:09:46 -0700 |
| commit | c18b812d127a971901180188b918a7cd98ccd4d6 (patch) | |
| tree | 3f2d0a7b1fada7aaade612d14dcaa7229a4e06c9 | |
| parent | 7540c1a77b26bc2f9d86a0bfbe6597b05ec5f93d (diff) | |
| download | linux-stable-c18b812d127a971901180188b918a7cd98ccd4d6.tar.gz linux-stable-c18b812d127a971901180188b918a7cd98ccd4d6.tar.bz2 linux-stable-c18b812d127a971901180188b918a7cd98ccd4d6.zip | |
ocfs2: Make transaction extend more efficient.
In ocfs2_extend_rotate_transaction, op_credits is the orignal
credits in the handle and we only want to extend the credits
for the rotation, but the old solution always double it. It
is harmless for some minor operations, but for actions like
reflink we may rotate tree many times and cause the credits
increase dramatically. So this patch try to only increase
the desired credits.
Signed-off-by: Tao Ma <tao.ma@oracle.com>
| -rw-r--r-- | fs/ocfs2/alloc.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 7c879fc7834f..38a42f5d59ff 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c @@ -2326,10 +2326,18 @@ static int ocfs2_extend_rotate_transaction(handle_t *handle, int subtree_depth, int op_credits, struct ocfs2_path *path) { + int ret; int credits = (path->p_tree_depth - subtree_depth) * 2 + 1 + op_credits; - if (handle->h_buffer_credits < credits) - return ocfs2_extend_trans(handle, credits); + if (handle->h_buffer_credits < credits) { + ret = ocfs2_extend_trans(handle, + credits - handle->h_buffer_credits); + if (ret) + return ret; + + if (unlikely(handle->h_buffer_credits < credits)) + return ocfs2_extend_trans(handle, credits); + } return 0; } |