summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>2018-09-17 17:26:41 +0900
committerTakashi Iwai <tiwai@suse.de>2018-09-17 13:41:14 +0200
commitc3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b (patch)
treef79472179806210280cb49c62be68b2260030424
parent1064bc685d359f549f91c2d5f111965a9284f328 (diff)
downloadlinux-stable-c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b.tar.gz
linux-stable-c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b.tar.bz2
linux-stable-c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b.zip
ALSA: fireworks: fix memory leak of response buffer at error path
After allocating memory object for response buffer, ALSA fireworks driver has leak of the memory object at error path. This commit releases the object at the error path. Fixes: 7d3c1d5901aa('ALSA: fireworks: delayed registration of sound card') Cc: <stable@vger.kernel.org> # v4.7+ Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/firewire/fireworks/fireworks.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
index 71a0613d3da0..f2d073365cf6 100644
--- a/sound/firewire/fireworks/fireworks.c
+++ b/sound/firewire/fireworks/fireworks.c
@@ -301,6 +301,8 @@ error:
snd_efw_transaction_remove_instance(efw);
snd_efw_stream_destroy_duplex(efw);
snd_card_free(efw->card);
+ kfree(efw->resp_buf);
+ efw->resp_buf = NULL;
dev_info(&efw->unit->device,
"Sound card registration failed: %d\n", err);
}