diff options
author | Guiting Shen <aarongt.shen@gmail.com> | 2023-06-26 23:27:13 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-07-25 17:39:10 +0200 |
commit | c55afcbeaa7a6f4fffdbc999a9bf3f0b29a5186f (patch) | |
tree | f7d869a38fc0f19ac69c496846692a32ee35be11 | |
parent | 13e098b58b8ff6d17f98f459dcc23ff064818e80 (diff) | |
download | linux-stable-c55afcbeaa7a6f4fffdbc999a9bf3f0b29a5186f.tar.gz linux-stable-c55afcbeaa7a6f4fffdbc999a9bf3f0b29a5186f.tar.bz2 linux-stable-c55afcbeaa7a6f4fffdbc999a9bf3f0b29a5186f.zip |
usb: ohci-at91: Fix the unhandle interrupt when resume
The ohci_hcd_at91_drv_suspend() sets ohci->rh_state to OHCI_RH_HALTED when
suspend which will let the ohci_irq() skip the interrupt after resume. And
nobody to handle this interrupt.
According to the comment in ohci_hcd_at91_drv_suspend(), it need to reset
when resume from suspend(MEM) to fix by setting "hibernated" argument of
ohci_resume().
Signed-off-by: Guiting Shen <aarongt.shen@gmail.com>
Cc: stable <stable@kernel.org>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20230626152713.18950-1-aarongt.shen@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/host/ohci-at91.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index b9ce8d80f20b..b805c4b52ac3 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -672,7 +672,13 @@ ohci_hcd_at91_drv_resume(struct device *dev) else at91_start_clock(ohci_at91); - ohci_resume(hcd, false); + /* + * According to the comment in ohci_hcd_at91_drv_suspend() + * we need to do a reset if the 48Mhz clock was stopped, + * that is, if ohci_at91->wakeup is clear. Tell ohci_resume() + * to reset in this case by setting its "hibernated" flag. + */ + ohci_resume(hcd, !ohci_at91->wakeup); return 0; } |