summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-24 22:00:21 +0100
committerDarren Hart <dvhart@linux.intel.com>2014-12-03 10:10:14 -0800
commitc6b7ef21098e9f6298e49ee59c28c6c1096faa07 (patch)
tree79c9bd565e208af020d8e0117b7f34e9025448b4
parent0098181016dd45c1c417656ba36b87d9101cbb83 (diff)
downloadlinux-stable-c6b7ef21098e9f6298e49ee59c28c6c1096faa07.tar.gz
linux-stable-c6b7ef21098e9f6298e49ee59c28c6c1096faa07.tar.bz2
linux-stable-c6b7ef21098e9f6298e49ee59c28c6c1096faa07.zip
Sony-laptop: Deletion of an unnecessary check before the function call "pci_dev_put"
The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
-rw-r--r--drivers/platform/x86/sony-laptop.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index a48cdc77f182..d25696f844fd 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -3716,8 +3716,7 @@ static void sony_pic_detect_device_type(struct sony_pic_dev *dev)
dev->event_types = type2_events;
out:
- if (pcidev)
- pci_dev_put(pcidev);
+ pci_dev_put(pcidev);
pr_info("detected Type%d model\n",
dev->model == SONYPI_DEVICE_TYPE1 ? 1 :