diff options
| author | Jing Yao <yao.jing2@zte.com.cn> | 2021-11-10 02:53:41 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-26 17:03:47 +0100 |
| commit | cd455ebb748c4e198c8158e5d61b3034bf10f22b (patch) | |
| tree | 6ccc2391750fbe880977a0a89b537a2f7f70e3e7 | |
| parent | 1f8ff525f3d316116892852d5d39eeefa9fcb217 (diff) | |
| download | linux-stable-cd455ebb748c4e198c8158e5d61b3034bf10f22b.tar.gz linux-stable-cd455ebb748c4e198c8158e5d61b3034bf10f22b.tar.bz2 linux-stable-cd455ebb748c4e198c8158e5d61b3034bf10f22b.zip | |
most: usb: replace snprintf in show functions with sysfs_emit
coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf
Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
sense.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
Link: https://lore.kernel.org/r/20211110025341.136194-1-yao.jing2@zte.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/most/most_usb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/most/most_usb.c b/drivers/most/most_usb.c index acabb7715b42..73258b24fea7 100644 --- a/drivers/most/most_usb.c +++ b/drivers/most/most_usb.c @@ -831,7 +831,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, int err; if (sysfs_streq(name, "arb_address")) - return snprintf(buf, PAGE_SIZE, "%04x\n", dci_obj->reg_addr); + return sysfs_emit(buf, "%04x\n", dci_obj->reg_addr); if (sysfs_streq(name, "arb_value")) reg_addr = dci_obj->reg_addr; @@ -843,7 +843,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, if (err < 0) return err; - return snprintf(buf, PAGE_SIZE, "%04x\n", val); + return sysfs_emit(buf, "%04x\n", val); } static ssize_t value_store(struct device *dev, struct device_attribute *attr, |