summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 16:33:55 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-10 16:36:05 +0200
commitcf03020c56d3ed28c4942280957a007b5e9544f7 (patch)
tree3ce183be7fc83821ec6f3a8ffc23801aa11377f6
parenta65f2b56334ba4dc30bd5ee9ce5b2691b973344d (diff)
downloadlinux-stable-cf03020c56d3ed28c4942280957a007b5e9544f7.tar.gz
linux-stable-cf03020c56d3ed28c4942280957a007b5e9544f7.tar.bz2
linux-stable-cf03020c56d3ed28c4942280957a007b5e9544f7.zip
smb: client: fix potential UAF in cifs_stats_proc_write()
commit d3da25c5ac84430f89875ca7485a3828150a7e0a upstream. Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/client/cifs_debug.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c
index 82cac8169602..b4d2ee2d5e6c 100644
--- a/fs/smb/client/cifs_debug.c
+++ b/fs/smb/client/cifs_debug.c
@@ -656,6 +656,8 @@ static ssize_t cifs_stats_proc_write(struct file *file,
}
#endif /* CONFIG_CIFS_STATS2 */
list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
atomic_set(&tcon->num_smbs_sent, 0);
spin_lock(&tcon->stat_lock);