summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2015-07-08 13:06:12 -0400
committerTejun Heo <tj@kernel.org>2015-07-15 11:56:40 -0400
commitd531be2ca2f27cca5f041b6a140504999144a617 (patch)
tree8422c4807b2f41708d3cd85eb26e3415368f7d2e
parentaf34d637637eabaf49406eb35c948cd51ba262a6 (diff)
downloadlinux-stable-d531be2ca2f27cca5f041b6a140504999144a617.tar.gz
linux-stable-d531be2ca2f27cca5f041b6a140504999144a617.tar.bz2
linux-stable-d531be2ca2f27cca5f041b6a140504999144a617.zip
libata: increase the timeout when setting transfer mode
I have a ST4000DM000 disk. If Linux is booted while the disk is spun down, the command that sets transfer mode causes the disk to spin up. The spin-up takes longer than the default 5s timeout, so the command fails and timeout is reported. Fix this by increasing the timeout to 15s, which is enough for the disk to spin up. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r--drivers/ata/libata-core.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 68202a8a3a0b..12b176a10d57 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4515,7 +4515,8 @@ static unsigned int ata_dev_set_xfermode(struct ata_device *dev)
else /* In the ancient relic department - skip all of this */
return 0;
- err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 0);
+ /* On some disks, this command causes spin-up, so we need longer timeout */
+ err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 15000);
DPRINTK("EXIT, err_mask=%x\n", err_mask);
return err_mask;