diff options
| author | Casper Andersson <casper.casan@gmail.com> | 2023-02-03 09:55:57 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-02-06 09:26:04 +0000 |
| commit | d7d94b2612f5dc25d61dc7bf58aafe7b31f40191 (patch) | |
| tree | f875c879a4a3ff3c5b9d40017808be3927177d6f | |
| parent | 03702d4d29be4e2510ec80b248dbbde4e57030d9 (diff) | |
| download | linux-stable-d7d94b2612f5dc25d61dc7bf58aafe7b31f40191.tar.gz linux-stable-d7d94b2612f5dc25d61dc7bf58aafe7b31f40191.tar.bz2 linux-stable-d7d94b2612f5dc25d61dc7bf58aafe7b31f40191.zip | |
net: microchip: sparx5: fix PTP init/deinit not checking all ports
Check all ports instead of just port_count ports. PTP init was only
checking ports 0 to port_count. If the hardware ports are not mapped
starting from 0 then they would be missed, e.g. if only ports 20-30 were
mapped it would attempt to init ports 0-10, resulting in NULL pointers
when attempting to timestamp. Now it will init all mapped ports.
Fixes: 70dfe25cd866 ("net: sparx5: Update extraction/injection for timestamping")
Signed-off-by: Casper Andersson <casper.casan@gmail.com>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c index 0ed1ea7727c5..69e76634f9aa 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c @@ -633,7 +633,7 @@ int sparx5_ptp_init(struct sparx5 *sparx5) /* Enable master counters */ spx5_wr(PTP_PTP_DOM_CFG_PTP_ENA_SET(0x7), sparx5, PTP_PTP_DOM_CFG); - for (i = 0; i < sparx5->port_count; i++) { + for (i = 0; i < SPX5_PORTS; i++) { port = sparx5->ports[i]; if (!port) continue; @@ -649,7 +649,7 @@ void sparx5_ptp_deinit(struct sparx5 *sparx5) struct sparx5_port *port; int i; - for (i = 0; i < sparx5->port_count; i++) { + for (i = 0; i < SPX5_PORTS; i++) { port = sparx5->ports[i]; if (!port) continue; |