diff options
| author | Thadeu Lima de Souza Cascardo <cascardo@canonical.com> | 2021-12-17 12:44:09 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-12-29 12:20:46 +0100 |
| commit | db0d90490674c297a2e15a1ca3e40cd6975c30dc (patch) | |
| tree | cbf596d05ba855cfdb9e192d61d4d8c269bc83b4 | |
| parent | f29fe79e02fcc0458c56553ee925ac93bed71e6e (diff) | |
| download | linux-stable-db0d90490674c297a2e15a1ca3e40cd6975c30dc.tar.gz linux-stable-db0d90490674c297a2e15a1ca3e40cd6975c30dc.tar.bz2 linux-stable-db0d90490674c297a2e15a1ca3e40cd6975c30dc.zip | |
ipmi: bail out if init_srcu_struct fails
commit 2b5160b12091285c5aca45980f100a9294af7b04 upstream.
In case, init_srcu_struct fails (because of memory allocation failure), we
might proceed with the driver initialization despite srcu_struct not being
entirely initialized.
Fixes: 913a89f009d9 ("ipmi: Don't initialize anything in the core until something uses it")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: Corey Minyard <cminyard@mvista.com>
Cc: stable@vger.kernel.org
Message-Id: <20211217154410.1228673-1-cascardo@canonical.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/char/ipmi/ipmi_msghandler.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 6db709e2c34b..2cbcf9f7935b 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -5085,7 +5085,9 @@ static int ipmi_init_msghandler(void) if (initialized) goto out; - init_srcu_struct(&ipmi_interfaces_srcu); + rv = init_srcu_struct(&ipmi_interfaces_srcu); + if (rv) + goto out; timer_setup(&ipmi_timer, ipmi_timeout, 0); mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES); |