diff options
author | Laurentiu Tudor <laurentiu.tudor@nxp.com> | 2018-09-26 16:22:32 +0300 |
---|---|---|
committer | Li Yang <leoyang.li@nxp.com> | 2018-10-05 14:01:46 -0500 |
commit | e0940b34c40e95d1879691d2474d182c57aae0de (patch) | |
tree | cc3fe309d2aa7f9360007a92c98ca09a12dac2c8 | |
parent | f1c98ee699314c6512522703b2bc0ed0afd08ad1 (diff) | |
download | linux-stable-e0940b34c40e95d1879691d2474d182c57aae0de.tar.gz linux-stable-e0940b34c40e95d1879691d2474d182c57aae0de.tar.bz2 linux-stable-e0940b34c40e95d1879691d2474d182c57aae0de.zip |
soc: fsl: bman_portals: defer probe after bman's probe
A crash in bman portal probing could not be triggered (as is the case
with qman portals) but it does make calls [1] into the bman driver so
lets make sure the bman portal probing happens after bman's.
[1] bman_p_irqsource_add() (in bman) called by:
init_pcfg() called by:
bman_portal_probe()
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
-rw-r--r-- | drivers/soc/fsl/qbman/bman_portal.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/soc/fsl/qbman/bman_portal.c b/drivers/soc/fsl/qbman/bman_portal.c index 088cdfa7c034..2c95cf59f3e7 100644 --- a/drivers/soc/fsl/qbman/bman_portal.c +++ b/drivers/soc/fsl/qbman/bman_portal.c @@ -93,7 +93,15 @@ static int bman_portal_probe(struct platform_device *pdev) struct device_node *node = dev->of_node; struct bm_portal_config *pcfg; struct resource *addr_phys[2]; - int irq, cpu; + int irq, cpu, err; + + err = bman_is_probed(); + if (!err) + return -EPROBE_DEFER; + if (err < 0) { + dev_err(&pdev->dev, "failing probe due to bman probe error\n"); + return -ENODEV; + } pcfg = devm_kmalloc(dev, sizeof(*pcfg), GFP_KERNEL); if (!pcfg) |