diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-05-03 18:09:55 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-05-11 16:17:53 +0300 |
| commit | e2ff1181b3d48257aab26bfd2165f3c7d271499f (patch) | |
| tree | f2265d4dfbe98b31d10758d7ea9a3d9543fe7442 | |
| parent | 7acd69507088b968beda8c2693591211fab333df (diff) | |
| download | linux-stable-e2ff1181b3d48257aab26bfd2165f3c7d271499f.tar.gz linux-stable-e2ff1181b3d48257aab26bfd2165f3c7d271499f.tar.bz2 linux-stable-e2ff1181b3d48257aab26bfd2165f3c7d271499f.zip | |
wifi: rtw88: unlock on error path in rtw_ops_add_interface()
Call mutex_unlock(&rtwdev->mutex); before returning on this error path.
Fixes: f0e741e4ddbc ("wifi: rtw88: add bitmap for dynamic port settings")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/ddd10a74-5982-4f65-8c59-c1cca558d239@kili.mountain
| -rw-r--r-- | drivers/net/wireless/realtek/rtw88/mac80211.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 7aa6edad0d01..02cd19ee6e4c 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -173,8 +173,10 @@ static int rtw_ops_add_interface(struct ieee80211_hw *hw, mutex_lock(&rtwdev->mutex); port = find_first_zero_bit(rtwdev->hw_port, RTW_PORT_NUM); - if (port >= RTW_PORT_NUM) + if (port >= RTW_PORT_NUM) { + mutex_unlock(&rtwdev->mutex); return -EINVAL; + } set_bit(port, rtwdev->hw_port); rtwvif->port = port; |