diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-09-05 22:22:21 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2017-09-07 10:26:19 +0200 |
| commit | e35e9ddfab7e6017b38b8b75cd13756530b3b2b6 (patch) | |
| tree | 08a666c79f9b2e319b8d239f9e63f4774b5239cc | |
| parent | 99dcad32376effb70bf466c70595edbbcbecd6d7 (diff) | |
| download | linux-stable-e35e9ddfab7e6017b38b8b75cd13756530b3b2b6.tar.gz linux-stable-e35e9ddfab7e6017b38b8b75cd13756530b3b2b6.tar.bz2 linux-stable-e35e9ddfab7e6017b38b8b75cd13756530b3b2b6.zip | |
ALSA: hdspm: Use common error handling code in snd_hdspm_probe()
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/rme9652/hdspm.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c index 25284d8d9758..f20d42714e4d 100644 --- a/sound/pci/rme9652/hdspm.c +++ b/sound/pci/rme9652/hdspm.c @@ -6949,10 +6949,8 @@ static int snd_hdspm_probe(struct pci_dev *pci, hdspm->pci = pci; err = snd_hdspm_create(card, hdspm); - if (err < 0) { - snd_card_free(card); - return err; - } + if (err < 0) + goto free_card; if (hdspm->io_type != MADIface) { snprintf(card->shortname, sizeof(card->shortname), "%s_%x", @@ -6970,15 +6968,17 @@ static int snd_hdspm_probe(struct pci_dev *pci, } err = snd_card_register(card); - if (err < 0) { - snd_card_free(card); - return err; - } + if (err < 0) + goto free_card; pci_set_drvdata(pci, card); dev++; return 0; + +free_card: + snd_card_free(card); + return err; } static void snd_hdspm_remove(struct pci_dev *pci) |