summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2012-04-09 22:50:15 +0200
committerJiri Kosina <jkosina@suse.cz>2012-04-30 13:17:53 +0200
commite3c5530b96b9c5994cfb2544a037161790c4f7c3 (patch)
tree16fb8e7fad5c07f990a57018cafbbfa4b0b67d99
parentb2cbf2e31bd26abaddcb1ce4cefb09e025247d52 (diff)
downloadlinux-stable-e3c5530b96b9c5994cfb2544a037161790c4f7c3.tar.gz
linux-stable-e3c5530b96b9c5994cfb2544a037161790c4f7c3.tar.bz2
linux-stable-e3c5530b96b9c5994cfb2544a037161790c4f7c3.zip
tg3: remove redundant NULL test before release_firmware() call
There is no need to test for a NULL pointer before calling release_firmware - the function does that on its own. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/net/ethernet/broadcom/tg3.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 062ac333fde6..9fbf73e41e30 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -15842,8 +15842,7 @@ static void __devexit tg3_remove_one(struct pci_dev *pdev)
if (dev) {
struct tg3 *tp = netdev_priv(dev);
- if (tp->fw)
- release_firmware(tp->fw);
+ release_firmware(tp->fw);
tg3_reset_task_cancel(tp);