diff options
| author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-04-25 12:32:01 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-27 16:52:21 -0400 |
| commit | e49d268db95b90f1fd97d4e3de1ec9f4bcfa8399 (patch) | |
| tree | b2b3ea1f026a31f9ae42ab293d835cf004e8e948 | |
| parent | 30e5a9a5ba853b896250f0665a2e10bbafa2f6bc (diff) | |
| download | linux-stable-e49d268db95b90f1fd97d4e3de1ec9f4bcfa8399.tar.gz linux-stable-e49d268db95b90f1fd97d4e3de1ec9f4bcfa8399.tar.bz2 linux-stable-e49d268db95b90f1fd97d4e3de1ec9f4bcfa8399.zip | |
net/tls: don't log errors every time offload can't proceed
Currently when CONFIG_TLS_DEVICE is set each time kTLS
connection is opened and the offload is not successful
(either because the underlying device doesn't support
it or e.g. it's tables are full) a rate limited error
will be printed to the logs.
There is nothing wrong with failing TLS offload. SW
path will process the packets just fine, drop the
noisy messages.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/tls/tls_device.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index cc0256939eb6..87e6cad7bace 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -865,8 +865,6 @@ int tls_set_device_offload_rx(struct sock *sk, struct tls_context *ctx) } if (!(netdev->features & NETIF_F_HW_TLS_RX)) { - pr_err_ratelimited("%s: netdev %s with no TLS offload\n", - __func__, netdev->name); rc = -ENOTSUPP; goto release_netdev; } @@ -894,11 +892,8 @@ int tls_set_device_offload_rx(struct sock *sk, struct tls_context *ctx) rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_RX, &ctx->crypto_recv.info, tcp_sk(sk)->copied_seq); - if (rc) { - pr_err_ratelimited("%s: The netdev has refused to offload this socket\n", - __func__); + if (rc) goto free_sw_resources; - } tls_device_attach(ctx, sk, netdev); goto release_netdev; |