diff options
| author | ruanjinjie <ruanjinjie@huawei.com> | 2022-11-10 09:19:29 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-09-23 10:47:04 +0200 |
| commit | e4ff88548defafb1ef84facd9856ec252da7b008 (patch) | |
| tree | 717591790d19d20be4eb5516f1d90f613648a7f0 | |
| parent | c3c0f0ddd851b3fa3e9d3450bbcd561f4f850469 (diff) | |
| download | linux-stable-e4ff88548defafb1ef84facd9856ec252da7b008.tar.gz linux-stable-e4ff88548defafb1ef84facd9856ec252da7b008.tar.bz2 linux-stable-e4ff88548defafb1ef84facd9856ec252da7b008.zip | |
powerpc/pseries: fix possible memory leak in ibmebus_bus_init()
[ Upstream commit afda85b963c12947e298ad85d757e333aa40fd74 ]
If device_register() returns error in ibmebus_bus_init(), name of kobject
which is allocated in dev_set_name() called in device_add() is leaked.
As comment of device_add() says, it should call put_device() to drop
the reference count that was set in device_initialize() when it fails,
so the name can be freed in kobject_cleanup().
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20221110011929.3709774-1-ruanjinjie@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | arch/powerpc/platforms/pseries/ibmebus.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c index 408a86044133..a3d6d064754e 100644 --- a/arch/powerpc/platforms/pseries/ibmebus.c +++ b/arch/powerpc/platforms/pseries/ibmebus.c @@ -452,6 +452,7 @@ static int __init ibmebus_bus_init(void) if (err) { printk(KERN_WARNING "%s: device_register returned %i\n", __func__, err); + put_device(&ibmebus_bus_device); bus_unregister(&ibmebus_bus_type); return err; |