diff options
| author | Jan Kara <jack@suse.cz> | 2025-02-06 10:46:58 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2025-03-17 11:19:41 -0400 |
| commit | e6eff39dd0fe4190c6146069cc16d160e71d1148 (patch) | |
| tree | b210964155e5b6e2fe8eb3b4a5589672f080ee03 | |
| parent | 5f920d5d60839f7cbbb1ed50eac68d8bc0a73a7c (diff) | |
| download | linux-stable-e6eff39dd0fe4190c6146069cc16d160e71d1148.tar.gz linux-stable-e6eff39dd0fe4190c6146069cc16d160e71d1148.tar.bz2 linux-stable-e6eff39dd0fe4190c6146069cc16d160e71d1148.zip | |
jbd2: remove wrong sb->s_sequence check
Journal emptiness is not determined by sb->s_sequence == 0 but rather by
sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a
valid transaction ID so the check can spuriously trigger. Remove the
invalid WARN_ON.
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20250206094657.20865-3-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/jbd2/journal.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index d8084b31b361..d210e8a82e66 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1869,7 +1869,6 @@ int jbd2_journal_update_sb_log_tail(journal_t *journal, tid_t tail_tid, /* Log is no longer empty */ write_lock(&journal->j_state_lock); - WARN_ON(!sb->s_sequence); journal->j_flags &= ~JBD2_FLUSHED; write_unlock(&journal->j_state_lock); |