diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-06 19:00:21 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-09-19 09:11:06 +0200 |
| commit | ead8b4f3b2f952e8cb0896d433dd293103807b35 (patch) | |
| tree | 89f7f9dc899ee468f6a79ff7894836a8472d86c6 | |
| parent | 009b3192339809720176b3e689bab00d2c513727 (diff) | |
| download | linux-stable-ead8b4f3b2f952e8cb0896d433dd293103807b35.tar.gz linux-stable-ead8b4f3b2f952e8cb0896d433dd293103807b35.tar.bz2 linux-stable-ead8b4f3b2f952e8cb0896d433dd293103807b35.zip | |
drm/mediatek: mtk_drm_drv.c: Add of_node_put() before goto
commit 165d42c012be69900f0e2f8545626cb9e7d4a832 upstream.
Each iteration of for_each_child_of_node puts the previous
node, but in the case of a goto from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
goto in two places.
Issue found with Coccinelle.
Fixes: 119f5173628a (drm/mediatek: Add DRM Driver for Mediatek SoC MT8173)
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index c021d4c8324f..7f5408cb2377 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -567,12 +567,15 @@ static int mtk_drm_probe(struct platform_device *pdev) comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); if (!comp) { ret = -ENOMEM; + of_node_put(node); goto err_node; } ret = mtk_ddp_comp_init(dev, node, comp, comp_id, NULL); - if (ret) + if (ret) { + of_node_put(node); goto err_node; + } private->ddp_comp[comp_id] = comp; } |