diff options
| author | Russell King <rmk+kernel@armlinux.org.uk> | 2017-11-30 13:59:21 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-12-01 15:18:42 -0500 |
| commit | ec7681bde6d0e53ea5ef564477c8656fc318023a (patch) | |
| tree | 622faf883171aba9a9b8b8af762b098f2f526ea2 | |
| parent | 710dfbb01a8ac0fc8d0cc191131bd84dc3796497 (diff) | |
| download | linux-stable-ec7681bde6d0e53ea5ef564477c8656fc318023a.tar.gz linux-stable-ec7681bde6d0e53ea5ef564477c8656fc318023a.tar.bz2 linux-stable-ec7681bde6d0e53ea5ef564477c8656fc318023a.zip | |
sfp: warn about modules requiring address change sequence
We do not support SFP modules which require the address change sequence
as detailed by SFF 8472 revision 1.22 section 8.9. Warn when these
modules are inserted, and treat them as SFF8079 modules for ethtool.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/sfp.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index c1aab6a81ce9..9dfc1c4c954f 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -487,6 +487,11 @@ static int sfp_sm_mod_probe(struct sfp *sfp) return -EINVAL; } + /* If the module requires address swap mode, warn about it */ + if (sfp->id.ext.diagmon & SFP_DIAGMON_ADDRMODE) + dev_warn(sfp->dev, + "module address swap to access page 0xA2 is not supported.\n"); + return sfp_module_insert(sfp->sfp_bus, &sfp->id); } @@ -652,7 +657,8 @@ static int sfp_module_info(struct sfp *sfp, struct ethtool_modinfo *modinfo) { /* locking... and check module is present */ - if (sfp->id.ext.sff8472_compliance) { + if (sfp->id.ext.sff8472_compliance && + !(sfp->id.ext.diagmon & SFP_DIAGMON_ADDRMODE)) { modinfo->type = ETH_MODULE_SFF_8472; modinfo->eeprom_len = ETH_MODULE_SFF_8472_LEN; } else { |