diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-05-09 12:07:11 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-05-24 17:32:43 +0100 |
| commit | ee1a221d947809c0308f27567c07a3ac93406057 (patch) | |
| tree | 48047215065957bd75b607b0d925c37cd77c52e1 | |
| parent | ea9c758184aebe46f3ab3bf318600be2b61f14bb (diff) | |
| download | linux-stable-ee1a221d947809c0308f27567c07a3ac93406057.tar.gz linux-stable-ee1a221d947809c0308f27567c07a3ac93406057.tar.bz2 linux-stable-ee1a221d947809c0308f27567c07a3ac93406057.zip | |
ALSA: firewire-digi00x: prevent potential use after free
[ Upstream commit c0e72058d5e21982e61a29de6b098f7c1f0db498 ]
This code was supposed to return an error code if init_stream()
failed, but it instead freed dg00x->rx_stream and returned success.
This potentially leads to a use after free.
Fixes: 9a08067ec318 ("ALSA: firewire-digi00x: support AMDTP domain")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/c224cbd5-d9e2-4cd4-9bcf-2138eb1d35c6@kili.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | sound/firewire/digi00x/digi00x-stream.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/firewire/digi00x/digi00x-stream.c b/sound/firewire/digi00x/digi00x-stream.c index a15f55b0dce3..295163bb8abb 100644 --- a/sound/firewire/digi00x/digi00x-stream.c +++ b/sound/firewire/digi00x/digi00x-stream.c @@ -259,8 +259,10 @@ int snd_dg00x_stream_init_duplex(struct snd_dg00x *dg00x) return err; err = init_stream(dg00x, &dg00x->tx_stream); - if (err < 0) + if (err < 0) { destroy_stream(dg00x, &dg00x->rx_stream); + return err; + } err = amdtp_domain_init(&dg00x->domain); if (err < 0) { |