diff options
author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-04 13:58:43 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-10 11:34:22 +0100 |
commit | eec2a09f89ffe4285a783775b9c967601c993cd0 (patch) | |
tree | 0376cace277322c999299c8a9be0c7d173ec072c | |
parent | dd45d60ecaf78d26a1af4ac3d20afd1cfc18d65f (diff) | |
download | linux-stable-eec2a09f89ffe4285a783775b9c967601c993cd0.tar.gz linux-stable-eec2a09f89ffe4285a783775b9c967601c993cd0.tar.bz2 linux-stable-eec2a09f89ffe4285a783775b9c967601c993cd0.zip |
of: unittest: fix memory leak in unittest_data_add
[ Upstream commit e13de8fe0d6a51341671bbe384826d527afe8d44 ]
In unittest_data_add, a copy buffer is created via kmemdup. This buffer
is leaked if of_fdt_unflatten_tree fails. The release for the
unittest_data buffer is added.
Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r-- | drivers/of/unittest.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index e6b175370f2e..8b7bd4822465 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1205,6 +1205,7 @@ static int __init unittest_data_add(void) of_fdt_unflatten_tree(unittest_data, NULL, &unittest_data_node); if (!unittest_data_node) { pr_warn("%s: No tree to attach; not running tests\n", __func__); + kfree(unittest_data); return -ENODATA; } |