summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Weinberger <richard@nod.at>2018-09-03 23:06:23 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-10-13 09:33:17 +0200
commitef37df3b8284c43ef0901c4c59d443ae790a31bb (patch)
treeb0700b21f2575ca3022377d2dc936e893dcf008a
parent09fbdca26741ce4dac3fdec6d5098f71cc607bc2 (diff)
downloadlinux-stable-ef37df3b8284c43ef0901c4c59d443ae790a31bb.tar.gz
linux-stable-ef37df3b8284c43ef0901c4c59d443ae790a31bb.tar.bz2
linux-stable-ef37df3b8284c43ef0901c4c59d443ae790a31bb.zip
ubifs: Check for name being NULL while mounting
commit 37f31b6ca4311b94d985fb398a72e5399ad57925 upstream. The requested device name can be NULL or an empty string. Check for that and refuse to continue. UBIFS has to do this manually since we cannot use mount_bdev(), which checks for this condition. Fixes: 1e51764a3c2ac ("UBIFS: add new flash file system") Reported-by: syzbot+38bd0f7865e5c6379280@syzkaller.appspotmail.com Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/ubifs/super.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index c5466c70d620..2a82aeeacba5 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1929,6 +1929,9 @@ static struct ubi_volume_desc *open_ubi(const char *name, int mode)
int dev, vol;
char *endptr;
+ if (!name || !*name)
+ return ERR_PTR(-EINVAL);
+
/* First, try to open using the device node path method */
ubi = ubi_open_volume_path(name, mode);
if (!IS_ERR(ubi))