summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiyu Yang <xiyuyang19@fudan.edu.cn>2020-04-20 23:14:19 +0800
committerTrond Myklebust <trond.myklebust@hammerspace.com>2020-04-21 19:11:59 -0400
commitefe57fd58e1cb77f9186152ee12a8aa4ae3348e0 (patch)
tree14724cd0203cf9f4dbac9a5435975bbe83a35042
parent7648f939cb919b9d15c21fff8cd9eba908d595dc (diff)
downloadlinux-stable-efe57fd58e1cb77f9186152ee12a8aa4ae3348e0.tar.gz
linux-stable-efe57fd58e1cb77f9186152ee12a8aa4ae3348e0.tar.bz2
linux-stable-efe57fd58e1cb77f9186152ee12a8aa4ae3348e0.zip
SUNRPC: Remove unreachable error condition
rpc_clnt_test_and_add_xprt() invokes rpc_call_null_helper(), which return the value of rpc_run_task() to "task". Since rpc_run_task() is impossible to return an ERR pointer, there is no need to add the IS_ERR() condition on "task" here. So we need to remove it. Fixes: 7f554890587c ("SUNRPC: Allow addition of new transports to a struct rpc_clnt") Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
-rw-r--r--net/sunrpc/clnt.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 325a0858700f..05404bb05607 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -2808,8 +2808,7 @@ int rpc_clnt_test_and_add_xprt(struct rpc_clnt *clnt,
task = rpc_call_null_helper(clnt, xprt, NULL,
RPC_TASK_SOFT|RPC_TASK_SOFTCONN|RPC_TASK_ASYNC|RPC_TASK_NULLCREDS,
&rpc_cb_add_xprt_call_ops, data);
- if (IS_ERR(task))
- return PTR_ERR(task);
+
rpc_put_task(task);
success:
return 1;