diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2023-07-10 18:49:23 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-07-10 18:27:45 +0100 |
| commit | f2daa4667fda1aa951b91da0ae9675a5da9d7716 (patch) | |
| tree | 70cfe33506e4d6e0e2e02903aff7d71c8447e130 | |
| parent | 2b308e7176e366a52a07a49868e3b1a295e56785 (diff) | |
| download | linux-stable-f2daa4667fda1aa951b91da0ae9675a5da9d7716.tar.gz linux-stable-f2daa4667fda1aa951b91da0ae9675a5da9d7716.tar.bz2 linux-stable-f2daa4667fda1aa951b91da0ae9675a5da9d7716.zip | |
spi: Use sysfs_emit() to instead of s*printf()
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230710154932.68377-7-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 125dea8fae00..eec2371ea52e 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -64,7 +64,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) if (len != -ENODEV) return len; - return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); + return sysfs_emit(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); } static DEVICE_ATTR_RO(modalias); @@ -89,7 +89,7 @@ static ssize_t driver_override_show(struct device *dev, ssize_t len; device_lock(dev); - len = snprintf(buf, PAGE_SIZE, "%s\n", spi->driver_override ? : ""); + len = sysfs_emit(buf, "%s\n", spi->driver_override ? : ""); device_unlock(dev); return len; } @@ -2814,8 +2814,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr, struct device *child; child = device_find_any_child(&ctlr->dev); - return sprintf(buf, "%s\n", - child ? to_spi_device(child)->modalias : NULL); + return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL); } static ssize_t slave_store(struct device *dev, struct device_attribute *attr, |