diff options
| author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-14 13:03:38 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-09-10 10:32:16 +0100 |
| commit | f51ddf376750556869e01aa3efacd356948b5f28 (patch) | |
| tree | 15f050e623028c5993aabbce253b0fc4e0694011 | |
| parent | 1aca2008e22f3735031b2630d289dfafec8abbf2 (diff) | |
| download | linux-stable-f51ddf376750556869e01aa3efacd356948b5f28.tar.gz linux-stable-f51ddf376750556869e01aa3efacd356948b5f28.tar.bz2 linux-stable-f51ddf376750556869e01aa3efacd356948b5f28.zip | |
cx82310_eth: fix a memory leak bug
[ Upstream commit 1eca92eef18719027d394bf1a2d276f43e7cf886 ]
In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc().
Then, the execution waits for the firmware to become ready. If the firmware
is not ready in time, the execution is terminated. However, the allocated
'dev->partial_data' is not deallocated on this path, leading to a memory
leak bug. To fix this issue, free 'dev->partial_data' before returning the
error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/usb/cx82310_eth.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/usb/cx82310_eth.c b/drivers/net/usb/cx82310_eth.c index 947bea81d924..dfbdea22fbad 100644 --- a/drivers/net/usb/cx82310_eth.c +++ b/drivers/net/usb/cx82310_eth.c @@ -175,7 +175,8 @@ static int cx82310_bind(struct usbnet *dev, struct usb_interface *intf) } if (!timeout) { dev_err(&udev->dev, "firmware not ready in time\n"); - return -ETIMEDOUT; + ret = -ETIMEDOUT; + goto err; } /* enable ethernet mode (?) */ |