diff options
| author | Shuming Fan <shumingf@realtek.com> | 2022-06-21 17:07:19 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-06-21 13:15:33 +0100 |
| commit | f69a10f84cb5ff0b1c6aef0e19e866bbe53ec7ea (patch) | |
| tree | e793185a39fd67f0df1a1b60b534250b3dbaa057 | |
| parent | 87912e97a1678d62877aab353ecfd201bc92b372 (diff) | |
| download | linux-stable-f69a10f84cb5ff0b1c6aef0e19e866bbe53ec7ea.tar.gz linux-stable-f69a10f84cb5ff0b1c6aef0e19e866bbe53ec7ea.tar.bz2 linux-stable-f69a10f84cb5ff0b1c6aef0e19e866bbe53ec7ea.zip | |
ASoC: rt711-sdca: fix kernel NULL pointer dereference when IO error
The initial settings will be written before the codec probe function.
But, the rt711->component doesn't be assigned yet.
If IO error happened during initial settings operations, it will cause the kernel panic.
This patch changed component->dev to slave->dev to fix this issue.
Signed-off-by: Shuming Fan <shumingf@realtek.com>
Link: https://lore.kernel.org/r/20220621090719.30558-1-shumingf@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/rt711-sdca.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/codecs/rt711-sdca.c b/sound/soc/codecs/rt711-sdca.c index dfe3c9299ebd..5ad53bbc8528 100644 --- a/sound/soc/codecs/rt711-sdca.c +++ b/sound/soc/codecs/rt711-sdca.c @@ -34,7 +34,7 @@ static int rt711_sdca_index_write(struct rt711_sdca_priv *rt711, ret = regmap_write(regmap, addr, value); if (ret < 0) - dev_err(rt711->component->dev, + dev_err(&rt711->slave->dev, "Failed to set private value: %06x <= %04x ret=%d\n", addr, value, ret); @@ -50,7 +50,7 @@ static int rt711_sdca_index_read(struct rt711_sdca_priv *rt711, ret = regmap_read(regmap, addr, value); if (ret < 0) - dev_err(rt711->component->dev, + dev_err(&rt711->slave->dev, "Failed to get private value: %06x => %04x ret=%d\n", addr, *value, ret); |