diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2018-12-29 01:43:48 +0000 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2019-02-25 08:40:58 +0100 |
| commit | f6a3d9d9dc1c86b75d858ebf011c7fff4b10a9bd (patch) | |
| tree | af127a2b4a6691cbf0c28c64f33ea338fc20ffb9 | |
| parent | 204d94e63e22d4bd4e8ce8af1aeeda2208822cd0 (diff) | |
| download | linux-stable-f6a3d9d9dc1c86b75d858ebf011c7fff4b10a9bd.tar.gz linux-stable-f6a3d9d9dc1c86b75d858ebf011c7fff4b10a9bd.tar.bz2 linux-stable-f6a3d9d9dc1c86b75d858ebf011c7fff4b10a9bd.zip | |
mmc: block: fix debugfs_simple_attr.cocci warnings
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/mmc/core/block.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 14f3fdb8c6bb..dc55bdfede92 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -2774,8 +2774,8 @@ static int mmc_dbg_card_status_get(void *data, u64 *val) return ret; } -DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get, - NULL, "%08llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get, + NULL, "%08llx\n"); /* That is two digits * 512 + 1 for newline */ #define EXT_CSD_STR_LEN 1025 @@ -2863,8 +2863,9 @@ static int mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md) if (mmc_card_mmc(card) || mmc_card_sd(card)) { md->status_dentry = - debugfs_create_file("status", S_IRUSR, root, card, - &mmc_dbg_card_status_fops); + debugfs_create_file_unsafe("status", 0400, root, + card, + &mmc_dbg_card_status_fops); if (!md->status_dentry) return -EIO; } |