diff options
| author | Jan Kara <jack@suse.cz> | 2022-04-01 12:27:46 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-04-17 19:34:22 -0600 |
| commit | fc84e1f941b91221092da5b3102ec82da24c5673 (patch) | |
| tree | b800fa4c33774c09d0b12521811aecc8f7e6dca4 | |
| parent | ea591cd4eb270393810e7be01feb8fde6a34fbbe (diff) | |
| download | linux-stable-fc84e1f941b91221092da5b3102ec82da24c5673.tar.gz linux-stable-fc84e1f941b91221092da5b3102ec82da24c5673.tar.bz2 linux-stable-fc84e1f941b91221092da5b3102ec82da24c5673.zip | |
bfq: Drop pointless unlock-lock pair
In bfq_insert_request() we unlock bfqd->lock only to call
trace_block_rq_insert() and then lock bfqd->lock again. This is really
pointless since tracing is disabled if we really care about performance
and even if the tracepoint is enabled, it is a quick call.
CC: stable@vger.kernel.org
Tested-by: "yukuai (C)" <yukuai3@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220401102752.8599-5-jack@suse.cz
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/bfq-iosched.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 1fc4d4628fba..19082e14f3c1 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -6150,11 +6150,8 @@ static void bfq_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq, return; } - spin_unlock_irq(&bfqd->lock); - trace_block_rq_insert(rq); - spin_lock_irq(&bfqd->lock); bfqq = bfq_init_rq(rq); if (!bfqq || at_head) { if (at_head) |