diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2022-05-27 23:28:18 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-14 16:59:30 +0200 |
| commit | fd6a0d88e31498c8c0ad15dcde860b2d37acef70 (patch) | |
| tree | e047dfee00a2fda07884a440ccc293fefd869875 | |
| parent | 0e1afd004f1a80be87d8c690cb36fc9d3b0ae472 (diff) | |
| download | linux-stable-fd6a0d88e31498c8c0ad15dcde860b2d37acef70.tar.gz linux-stable-fd6a0d88e31498c8c0ad15dcde860b2d37acef70.tar.bz2 linux-stable-fd6a0d88e31498c8c0ad15dcde860b2d37acef70.zip | |
md: bcache: check the return value of kzalloc() in detached_dev_do_request()
commit 40f567bbb3b0639d2ec7d1c6ad4b1b018f80cf19 upstream.
The function kzalloc() in detached_dev_do_request() can fail, so its
return value should be checked.
Fixes: bc082a55d25c ("bcache: fix inaccurate io state for detached bcache devices")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Coly Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20220527152818.27545-4-colyli@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/md/bcache/request.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index c1e487d1261c..958c3a1c453a 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1102,6 +1102,12 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio) * which would call closure_get(&dc->disk.cl) */ ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); + if (!ddip) { + bio->bi_status = BLK_STS_RESOURCE; + bio->bi_end_io(bio); + return; + } + ddip->d = d; ddip->start_time = jiffies; ddip->bi_end_io = bio->bi_end_io; |