summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPrashant Malani <pmalani@chromium.org>2021-09-28 03:19:30 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-10-20 11:45:06 +0200
commitfdaff7f9e806fe241de0c4613ab6615000db23e9 (patch)
treef4ae2df5c5b14444a8ce37651a747461d1c7df00
parent057ee6843bbbe9e7114b6b35b6beab655288df24 (diff)
downloadlinux-stable-fdaff7f9e806fe241de0c4613ab6615000db23e9.tar.gz
linux-stable-fdaff7f9e806fe241de0c4613ab6615000db23e9.tar.bz2
linux-stable-fdaff7f9e806fe241de0c4613ab6615000db23e9.zip
platform/x86: intel_scu_ipc: Fix busy loop expiry time
commit 41512e4dc0b84525495e784295092592adb87f1b upstream. The macro IPC_TIMEOUT is already in jiffies (it is also used like that elsewhere in the file when calling wait_for_completion_timeout()). Don’t convert it using helper functions for the purposes of calculating the busy loop expiry time. Fixes: e7b7ab3847c9 (“platform/x86: intel_scu_ipc: Sleeping is fine when polling”) Signed-off-by: Prashant Malani <pmalani@chromium.org> Cc: Benson Leung <bleung@chromium.org> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Link: https://lore.kernel.org/r/20210928101932.2543937-2-pmalani@chromium.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/platform/x86/intel_scu_ipc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
index d9cf7f7602b0..425d2064148f 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -232,7 +232,7 @@ static inline u32 ipc_data_readl(struct intel_scu_ipc_dev *scu, u32 offset)
/* Wait till scu status is busy */
static inline int busy_loop(struct intel_scu_ipc_dev *scu)
{
- unsigned long end = jiffies + msecs_to_jiffies(IPC_TIMEOUT);
+ unsigned long end = jiffies + IPC_TIMEOUT;
do {
u32 status;