summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarco Pagani <marpagan@redhat.com>2022-06-09 16:05:19 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-08-25 11:15:14 +0200
commitfe4834af3df005e4f792332f5db3a4ff73d3e700 (patch)
tree04e8bac3a93c211c00db2596c18c7e43ff7c588a
parent9ae20c4af2af4cb26292c8029fa990a8a8123c8c (diff)
downloadlinux-stable-fe4834af3df005e4f792332f5db3a4ff73d3e700.tar.gz
linux-stable-fe4834af3df005e4f792332f5db3a4ff73d3e700.tar.bz2
linux-stable-fe4834af3df005e4f792332f5db3a4ff73d3e700.zip
fpga: altera-pr-ip: fix unsigned comparison with less than zero
[ Upstream commit 2df84a757d87fd62869fc401119d429735377ec5 ] Fix the "comparison with less than zero" warning reported by cppcheck for the unsigned (size_t) parameter count of the alt_pr_fpga_write() function. Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP") Reviewed-by: Tom Rix <trix@redhat.com> Acked-by: Xu Yilun <yilun.xu@intel.com> Signed-off-by: Marco Pagani <marpagan@redhat.com> Link: https://lore.kernel.org/r/20220609140520.42662-1-marpagan@redhat.com Signed-off-by: Xu Yilun <yilun.xu@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/fpga/altera-pr-ip-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
index 65e0b6a2c031..059ba27f3c29 100644
--- a/drivers/fpga/altera-pr-ip-core.c
+++ b/drivers/fpga/altera-pr-ip-core.c
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
u32 *buffer_32 = (u32 *)buf;
size_t i = 0;
- if (count <= 0)
+ if (!count)
return -EINVAL;
/* Write out the complete 32-bit chunks */