summaryrefslogtreecommitdiffstats
path: root/Kconfig
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2020-02-19 22:23:09 -0800
committerDavid S. Miller <davem@davemloft.net>2020-02-20 10:00:19 -0800
commit16a556eeb7ed2dc3709fe2c5be76accdfa4901ab (patch)
tree71790487b4158ae58a11398f1e72768edd1919e5 /Kconfig
parent46d30cb1045c2ab1ada269702c8c84d6446baf81 (diff)
downloadlinux-stable-16a556eeb7ed2dc3709fe2c5be76accdfa4901ab.tar.gz
linux-stable-16a556eeb7ed2dc3709fe2c5be76accdfa4901ab.tar.bz2
linux-stable-16a556eeb7ed2dc3709fe2c5be76accdfa4901ab.zip
openvswitch: Distribute switch variables for initialization
Variables declared in a switch statement before any case statements cannot be automatically initialized with compiler instrumentation (as they are not part of any execution flow). With GCC's proposed automatic stack variable initialization feature, this triggers a warning (and they don't get initialized). Clang's automatic stack variable initialization (via CONFIG_INIT_STACK_ALL=y) doesn't throw a warning, but it also doesn't initialize such variables[1]. Note that these warnings (or silent skipping) happen before the dead-store elimination optimization phase, so even when the automatic initializations are later elided in favor of direct initializations, the warnings remain. To avoid these problems, move such variables into the "case" where they're used or lift them up into the main function body. net/openvswitch/flow_netlink.c: In function ‘validate_set’: net/openvswitch/flow_netlink.c:2711:29: warning: statement will never be executed [-Wswitch-unreachable] 2711 | const struct ovs_key_ipv4 *ipv4_key; | ^~~~~~~~ [1] https://bugs.llvm.org/show_bug.cgi?id=44916 Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Kconfig')
0 files changed, 0 insertions, 0 deletions